Home / Projects / Orchestrata Ultimate / Decisions / ADR index / ADR-0078

ADR-0078: The deployed codemod daemon reviews with every phase; the tools venv carries the free-threaded janus-swi

← ADR-0077 · ADR-0079 →

The record

Status: Proposed · Date: 2026-10-08

Context

/opt/orchestrata-tools (deploy/install-tools.sh) vendored four hand-listed subtrees of orchestrata_ultimate. Measured 2026-10-08 on master 1d5f3e52c (scratch import_closure.py, then scripts/tools_import_closure.py):

• the eager import closure of refactor.codemod._daemon_entry is 1 module — every import in the daemon is lazy, which is why the deploy smoke passed;
• the eager closure of the daemon plus refactor.codemod.review_checks — what the first InMemoryReviewEngine(registry=None) review executes — is 103 modules over six packages (core 40, refactor 34, verification 14, openspec 7, knowledge_graph 2, orchestrata_ast 5); verification and openspec were never vendored, so the first default review in the deployed daemon raised ModuleNotFoundError (task 580). The 2026-10-08 ship of 3bb5319df failed at exactly this smoke when the import was briefly eager;
• the all-scopes closure of every deployed entry is 167 modules over nine packages (adds providers, llm, memory on lazy paths).

WI-DEPLOY (plans/recorded-run-2026-10-08-eight-failures-design.md §3.2, worktree wt-TOOLS-CLOSURE, commits 1d51e674d a49aea09d) made the vendor list computed and gate-pinned (deploy/tools-vendor-manifest.txt == ClosureReport.vendor_manifest() of the all-scopes closure) and made the deploy smoke construct the engine and review a two-file workspace. That smoke now passes — and prints PrologSemanticReview: janus-swi not available, skipping: the deployed review runs phases 1 and 2 only. janus_swi is a lazy third-party import on the review path; the project's own venv carries the patched free-threaded build (scripts/_janus_patched, scripts/build_janus_ft.py, janus_swi-1.5.3 in /opt/orchestrata/.venv), because upstream janus-swi re-enables the GIL process-wide on import (SPEC-023, the same class as the msgpack/grpcio incidents, task 184).

A review that silently drops its semantic phase is the false-green class this project forbids (RUL-009, docs/kernel-is-required.md): the daemon answers "reviewed" while the Prolog checks never ran.

Decision (proposed)

1. The deployed codemod daemon reviews with every phase its in-repo twin runs. deploy/install-tools.sh installs into the tools venv the same free-threaded janus-swi artifact the project venv uses (the wheel scripts/build_janus_ft.py produces, from the pinned [tool.uv.sources] path), never upstream janus-swi from PyPI.
2. The deploy smoke asserts the Prolog phase ran: the default-review smoke fails on the janus-swi not available, skipping line (or on any phase-3 skip marker), and asserts the venv interpreter still reports the GIL disabled after import janus_swi.
3. The vendor list stays the all-scopes computed closure (nine packages), pinned by tests/deploy/test_tools_vendor_manifest.py; the eager closure is reported, not vendored, because a lazy path that is reachable in the daemon is a path the daemon will take.
4. Third-party packages reachable only on lazy paths (httpx, redis, tiktoken, pyyaml) are installed when tools_import_closure.py --pip lists them for a deployed entry; the installer's pip line is derived from that output, as WI-DEPLOY already wired.

Alternatives rejected

• Ship phases 1–2 only and document it. The daemon's review result is then a different artifact from the repo's, with no marker in the result — the deployed thing is not the tested thing (RUL-012, RUL-027).
• Install upstream janus-swi from PyPI in the tools venv. Re-enables the GIL for the daemon process (measured for janus in SPEC-023 work); the free-threaded daemon becomes a serialized one and the sys._is_gil_enabled() smoke fails.
• Vendor the eager closure only (six packages). Smaller archive, but every lazy path (providers, llm, memory) is one more latent ModuleNotFoundError of the task-580 class.

Consequences

• The tools deploy depends on the free-threaded janus wheel being buildable or present on the host (scripts/check_native_build_freshness.py already gates staleness of such builds); a host without it fails the install loudly, which is the intended behaviour.
• review_engine.py's comment that the tools deploy "does not vendor" verification is stale after WI-DEPLOY and is corrected with this ADR's implementation.
• Gates: tests/deploy/test_tools_vendor_manifest.py (manifest == closure), the installer smoke (default review runs, phase 3 ran, GIL off).

Provenance

Orchestrator (Claude Code, Fable 5.1) on 2026-10-08, from the WI-DEPLOY worker's report ("PrologSemanticReview: janus-swi not available, skipping … Decision for you") during the eight-failures swarm (plans/recorded-run-2026-10-08-eight-failures-design.md). Evidence: scratchpad/install2.log of the scratch-prefix install; closure counts from scripts/tools_import_closure.py; task 580; task 184 (janus/msgpack GIL re-enable). Awaiting Mohamed's ruling.

Related ADRs

No other ADR is named in this record.

Rulings cited

• RUL-009: RUL-009 — Never run tests without live observation
• RUL-012: RUL-012 — Done means wired and deployed, not just built and tested
• RUL-027: RUL-027 — Production runs its own checkout, never the development tree

Specs cited

• SPEC-023